On 2020-Jul-06, Alvaro Herrera wrote: > On 2020-Jul-07, Kyotaro Horiguchi wrote:
> > Couldn't we move ConvertToXSegs from xlog.c to xlog_ingernals.h and > > use it intead of the bare expression? > > I was of two minds about that, and the only reason I didn't do it is > that we'll need to give it a better name if we do it ... I'm open to > suggestions. In absence of other suggestions I gave this the name XLogMBVarToSegs, and redefined ConvertToXSegs to use that. Didn't touch callers in xlog.c to avoid pointless churn. Pushed to both master and 13. I hope this satisfies everyone ... Masao-san, thanks for reporting the problem, and thanks Horiguchi-san for providing the fix. (Also thanks to Amit and Michael for discussion.) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
