On Mon, 6 Jul 2020 at 09:35, Dave Cramer <davecra...@gmail.com> wrote:

>
>
> On Mon, 6 Jul 2020 at 09:03, Daniel Gustafsson <dan...@yesql.se> wrote:
>
>> > On 6 Jul 2020, at 14:58, Dave Cramer <davecra...@gmail.com> wrote:
>>
>> > as far as rebase -i do what is advised here for squashing them. Just
>> one patch now ?
>>
>> One patch per logical change, if there are two disjoint changes in the
>> patchset
>> where one builds on top of the other then multiple patches are of course
>> fine.
>> My personal rule-of-thumb is to split it the way I envision it committed.
>>
>
> At this point it is the result of 3 rebases. I guess I'll have to break it
> up differently..
>
>
OK, rebased it down to 2 patches, attached.



> Thanks,
>
> Dave
>

Attachment: 0001-Add-binary-protocol-for-publications-and-subscriptio.patch
Description: Binary data

Attachment: 0002-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch
Description: Binary data

Reply via email to