On Mon, 6 Jul 2020 at 09:03, Daniel Gustafsson <dan...@yesql.se> wrote:

> > On 6 Jul 2020, at 14:58, Dave Cramer <davecra...@gmail.com> wrote:
>
> > as far as rebase -i do what is advised here for squashing them. Just one
> patch now ?
>
> One patch per logical change, if there are two disjoint changes in the
> patchset
> where one builds on top of the other then multiple patches are of course
> fine.
> My personal rule-of-thumb is to split it the way I envision it committed.
>

At this point it is the result of 3 rebases. I guess I'll have to break it
up differently..

Thanks,

Dave

Reply via email to