ср, 1 июл. 2020 г. в 23:16, Tom Lane <t...@sss.pgh.pa.us>: > Pavel Borisov <pashkin.e...@gmail.com> writes: > > Below is my variant how to patch Gin-Gist weights issue: > > I looked at this patch, but I'm unimpressed, because it's buggy. >
Thank you, i'd noticed and made minor corrections in the patch. Now it should work correctly, As for preserving the option to use legacy bool-style calls, personally I see much value of not changing API ad hoc to fix something. This may not harm vanilla reseases but can break many possible side things like RUM index etc which I think are abundant around there. Furthermore if we leave legacy bool callback along with newly proposed and recommended for further use it will cost nothing. So I've attached a corrected patch. Also I wrote some comments to the code and added your test as a part of apatch. Again thank you for sharing your thoughts and advice. As always I'd appreciate everyone's opinion on the bugfix. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
gin-gist-weight-patch-v4.diff
Description: Binary data
