> On 29 Jun 2020, at 17:52, Felix Lechner <felix.lech...@lease-up.com> wrote:

> This patch removes two temporary files that are not removed. In
> Debian, repeated builds fail. We do not allow builds from modified
> sources.

Aha, nice catch!

> The first file was clearly an oversight. It was created separately. I
> am not sure why the loop over @keys did not remove the second.

That's because it's created in the 002_scram.pl testsuite as well, but not
cleaned up there.

The proposed patch admittedly seems a bit like a hack, and the client_tmo.key
handling is wrong as mentioned above.  I propose that we instead add the key to
the @keys array and have clean up handle all files uniformly.  The attached
fixes both of the files.

cheers ./daniel

Attachment: tls_tests_cleanup.patch
Description: Binary data


Reply via email to