Hi, This patch removes two temporary files that are not removed. In Debian, repeated builds fail. We do not allow builds from modified sources.
The first file was clearly an oversight. It was created separately. I am not sure why the loop over @keys did not remove the second. For the record, the error message from Debian is below. Lines 25-27 show the files that were left behind. Kind regards, Felix Lechner lechner@4bba56c5a8a8:~/postgresql$ debuild dpkg-buildpackage -us -uc -ui dpkg-buildpackage: info: source package postgresql-13 dpkg-buildpackage: info: source version 13~beta2-1 dpkg-buildpackage: info: source distribution experimental dpkg-buildpackage: info: source changed by Christoph Berg <m...@debian.org> dpkg-source --before-build . dpkg-buildpackage: info: host architecture amd64 fakeroot debian/rules clean dh clean debian/rules override_dh_auto_clean make[1]: Entering directory '/home/lechner/postgresql' rm -rf build make[1]: Leaving directory '/home/lechner/postgresql' dh_autoreconf_clean dh_clean dpkg-source -b . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: building postgresql-13 using existing ./postgresql-13_13~beta2.orig.tar.bz2 dpkg-source: info: using patch list from debian/patches/series dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override dpkg-source: warning: ignoring deletion of file src/include/pg_config.h.in, use --include-removal to override dpkg-source: warning: ignoring deletion of file doc/src/sgml/man-stamp, use --include-removal to override dpkg-source: warning: ignoring deletion of file doc/src/sgml/html-stamp, use --include-removal to override dpkg-source: info: local changes detected, the modified files are: postgresql/src/test/ssl/ssl/client_tmp.key postgresql/src/test/ssl/ssl/client_wrongperms_tmp.key dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/postgresql-13_13~beta2-1.diff.gy3ajb dpkg-source: info: you can integrate the local changes with dpkg-source --commit dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2 debuild: fatal error at line 1182: dpkg-buildpackage -us -uc -ui failed
+++ b/src/test/ssl/t/001_ssltests.pl @@ -544,6 +544,8 @@ test_connect_fails($common_connstr, "ssl qr/SSL error/, "intermediate client certificate is missing"); # clean up +unlink("ssl/client_wrongperms_tmp.key"); +unlink("ssl/client_tmp.key"); foreach my $key (@keys) { unlink("ssl/${key}_tmp.key");