On Tue, Jun 9, 2020 at 6:45 PM Georgios <gkokola...@protonmail.com> wrote: >
> > Please add it to the commitfest at https://commitfest.postgresql.org/28/ > > Thank you very much for your time. Added to the commitfest as suggested. Patch applies cleanly, make check & make check-world passes. Few comments: + if (pset.sversion >= 120000) + appendPQExpBufferStr(&buf, + "\n LEFT JOIN pg_catalog.pg_am am ON am.oid = c.relam"); Should we include pset.hide_tableam check along with the version check? + if (pset.sversion >= 120000 && !pset.hide_tableam) + { + appendPQExpBuffer(&buf, + ",\n am.amname as \"%s\"", + gettext_noop("Access Method")); + } Braces can be removed & the second line can be combined with earlier. We could include the test in psql file by configuring HIDE_TABLEAM. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
