On Fri, May 15, 2020 at 2:10 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > I have one question related to this; Why don't we use log_timezone, > like backup_label? log_timezone is used for "START TIME" field in > backup_label. Sorry if this was already discussed. > > /* Use the log timezone here, not the session timezone */ > stamp_time = (pg_time_t) time(NULL); > pg_strftime(strfbuf, sizeof(strfbuf), > "%Y-%m-%d %H:%M:%S %Z", > pg_localtime(&stamp_time, > log_timezone)); > > OTOH, *if* we want to use the same timezone for backup-related files because > backup can be used in different environements and timezone setting > may be different there or for other reasons, backup_label also should use > GMT or something for the sake of consistency?
It's a good question. My inclination was to think that GMT would be the clearest thing, but I also didn't realize that the result would thus be inconsistent with backup_label. Not sure what's best here. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
