Re: Poll: are people okay with function/operator table redesign?

[Jonathan S. Katz]

On 4/29/20 10:38 PM, Tom Lane wrote:
> "Jonathan S. Katz" <jk...@postgresql.org> writes:
>> Please see latest attached. I've eliminated the !important, condensed
>> the CSS, and the desultory (yes, my word of the week) testing did not
>> find issues in devel or earlier versions.
> 
>> Please let me know if this works for you. If it does, I'll push it up to
>> pgweb.
> 
> NAK ... that does *not* work for me.

Learned a new acronym...

> It looks to me like you are expecting that "margin" with four parameters
> will override an outer-level setting of margin-bottom, but that is not
> how my browser is responding.  ISTM you need to explicitly set the very
> same parameters in the more-specific rule as in the less-specific rule
> that you want to override.
> 
> I get reasonable results with these settings, but not with
> anything more abbreviated:

> In particular, it might look like the multiple padding settings
> in the pre.programlisting rule are redundant ... but they are not, at
> least not with Safari.

Clearly I was caught doing a single browser test (Chrome).

Reverted back to the verbose way sans !important, attached, which
appears to be the consensus. If you can ACK this, I'll commit.

Thanks,

Jonathan

diff --git a/media/css/main.css b/media/css/main.css
index 08ca255..2b4831d 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -625,7 +625,7 @@ ul.actions {
 }
 
 #docContent p {
-  margin-bottom: 1rem !important;
+  margin-bottom: 1rem;
 }
 
 #docContent hr {
@@ -648,7 +648,7 @@ ul.actions {
 }
 
 #docContent pre {
-  padding: 0.8rem !important;
+  padding: 0.8rem;
 }
 
 pre,
@@ -658,7 +658,7 @@ code,
 #docContent tt.REPLACEABLE {
   font-size: 0.9rem !important;
   color: inherit !important;
-  background-color: #f8f9fa !important;
+  background-color: #f8f9fa;
   border-radius: .25rem;
   margin: .6rem 0;
   font-weight: 300;
@@ -799,6 +799,27 @@ code,
        text-align: left;
 }
 
+#docContent table.table th.func_table_entry p,
+#docContent table.table td.func_table_entry p {
+  margin-top: 0.1em;
+  margin-bottom: 0.1em;
+  padding-left: 4em;
+  text-align: left;
+}
+
+#docContent table.table p.func_signature {
+  text-indent: -3.5em;
+}
+
+#docContent table.table td.func_table_entry pre.programlisting {
+  background-color: inherit;
+  border: 0;
+  margin-bottom: 0.1em;
+  margin-top: 0.1em;
+  padding: 0;
+  padding-left: 4em;
+}
+
 /**
  * Titles, Navigation
  */
@@ -1059,7 +1080,7 @@ i.fas.fa-search {
 pre {
   padding: 0.8rem;
   border: 1px solid #ced4da;
-  margin: 1rem 0 !important;
+  margin: 1rem 0;
 }
 
 pre.code {

signature.asc
Description: OpenPGP digital signature