On 2020/04/15 11:18, Fujii Masao wrote:
On 2020/04/14 0:15, Robert Haas wrote:
On Sun, Apr 12, 2020 at 10:09 PM Fujii Masao
<masao.fu...@oss.nttdata.com> wrote:
I found other minor issues.
I think these are all correct fixes. Thanks for the post-commit
review, and sorry for this mistakes.
Thanks for the review, Michael and Robert. Pushed the patches!
I found three minor issues in pg_verifybackup.
+ {"print-parse-wal", no_argument, NULL, 'p'},
This is unused option, so this line should be removed.
+ printf(_(" -m, --manifest=PATH use specified path for
manifest\n"));
Typo: --manifest should be --manifest-path
pg_verifybackup accepts --quiet option, but its usage() doesn't
print any message for --quiet option.
Attached is the patch that fixes those issues.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c
b/src/bin/pg_verifybackup/pg_verifybackup.c
index 9c0a8c5550..340765526d 100644
--- a/src/bin/pg_verifybackup/pg_verifybackup.c
+++ b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -162,7 +162,6 @@ main(int argc, char **argv)
{"ignore", required_argument, NULL, 'i'},
{"manifest-path", required_argument, NULL, 'm'},
{"no-parse-wal", no_argument, NULL, 'n'},
- {"print-parse-wal", no_argument, NULL, 'p'},
{"quiet", no_argument, NULL, 'q'},
{"skip-checksums", no_argument, NULL, 's'},
{"wal-directory", required_argument, NULL, 'w'},
@@ -894,8 +893,9 @@ usage(void)
printf(_("Options:\n"));
printf(_(" -e, --exit-on-error exit immediately on error\n"));
printf(_(" -i, --ignore=RELATIVE_PATH ignore indicated path\n"));
- printf(_(" -m, --manifest=PATH use specified path for
manifest\n"));
+ printf(_(" -m, --manifest-path=PATH use specified path for
manifest\n"));
printf(_(" -n, --no-parse-wal do not try to parse WAL
files\n"));
+ printf(_(" -q, --quiet do not print any output, except
for errors\n"));
printf(_(" -s, --skip-checksums skip checksum verification\n"));
printf(_(" -w, --wal-directory=PATH use specified path for WAL
files\n"));
printf(_(" -V, --version output version information,
then exit\n"));
