On Thu, Feb 27, 2020 at 4:50 PM Antonin Houska <a...@cybertec.at> wrote:
> legrand legrand <legrand_legr...@hotmail.com> wrote: > > > Antonin Houska-2 wrote > > > > Right now I recall two problems: 1) is the way I currently store > > > RelOptInfo for the grouped relations correct?, 2) how should we handle > > > types for which logical equality does not imply physical (byte-wise) > > > equality? > > > > > > Fortunately it seems now that I'm not the only one who cares about 2), > so > > > this > > > problem might be resolved soon: > > > > > > > https://www.postgresql.org/message-id/CAH2-Wzn3Ee49Gmxb7V1VJ3-AC8fWn-Fr8pfWQebHe8rYRxt5OQ%40mail.gmail.com > > > > > > But 1) still remains. > > > > > > > Hello > > would "pgsql: Add equalimage B-Tree support functions." > > > https://www.postgresql.org/message-id/e1j72ny-0002gi...@gemulon.postgresql.org > > Yes, it seems so. I'll adapt the patch soon, hopefully next week. Thanks > for > reminder. > > -- > Antonin Houska > Web: https://www.cybertec-postgresql.com > > Hi Antonin: The more tests on your patch, the more powerful I feel it is! At the same time, I think the most difficult part to understand your design is you can accept any number of generic join clauses, so I guess more explanation on this part may be helpful. At the code level, I did some slight changes on init_grouping_targets which may make the code easier to read. You are free to to use/not use it. Hope your patch get more attention soon! Best Regards Andy Fan
v2-0001-tiny-changes-for-init_grouping_targets.patch
Description: Binary data
