On Mon, Apr 6, 2020 at 10:09 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > James Coleman <jtc...@gmail.com> writes: > > On Mon, Apr 6, 2020 at 9:46 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > >> I think the correct fix is to change the enum declaration. > > > Hmm. I don't actually really like that, because it means the value > > here isn't actually semantically correct. That is, the sort type is > > not "in progress"; it's "we never started a sort at all". > > Well, yeah, but that pre-dated this patch, and right now is no > time to improve it; we can debate such fine points at more leisure > once the buildfarm isn't broken.
Fair enough. Unsure if Tomas is still online to comment and/or push, but reverting SORT_TYPE_STILL_IN_PROGRESS back to 0 works for me as an initial fix. > Obviously the comment needs fixed... The one in show_short_info? I can work on that (and the other proposed cleanup above) with Tomas tomorrow or later. James
