On 2020/03/15 19:32, Peter Eisentraut wrote:
On 2020-03-13 22:24, Peter Eisentraut wrote:
On 2020-03-10 19:07, Alvaro Herrera wrote:
I like these patches; the first two are nice cleanup.
My only gripe is that pgstat_get_backend_desc() is not really a pgstat
function; I think it should have a different name with a prototype in
miscadmin.h (next to the enum's new location, which I would put
someplace near the "pmod.h" comment rather than where you put it;
perhaps just above the AuxProcType definition), and implementation
probably in miscinit.c.
I have committed the refactoring patches with adjustments along these
lines. The patch with the log_line_prefix and csvlog enhancements is
still under discussion.
I have committed that last one also, after some corrections.
Thanks for adding this nice feature!
I have one comment; You seem to need to update file-fdw.sgml so that
pglog table in the doc should include backend_type column.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
