On 3/3/20, 12:24 PM, "Alvaro Herrera" <alvhe...@2ndquadrant.com> wrote: > IMO: is_dir should be there (and subdirs should be listed), but > parent_dir should not appear. Also, the "path" should show the complete > pathname, including containing dirs, starting from whatever the "root" > is for the operation. > > So for the example in the initial email, it would look like > > path isdir > pgsql_tmp11025.0.sharedfileset/ t > pgsql_tmp11025.0.sharedfileset/0.0 f > pgsql_tmp11025.0.sharedfileset/1.0 f > > plus additional columns, same as pg_ls_waldir et al. > > I'd rather not have the code assume that there's a single level of > subdirs, or assuming that an entry in the subdir cannot itself be a dir; > that might end up hiding files for no good reason.
+1 Nathan
