On Tue, Feb 25, 2020 at 10:44:40PM +0100, Daniel Gustafsson wrote: > In doing that I realized that there is another hunk in this patch for fixing > up > logical decoding multi-insert support, which is independent of the patch in > question here so I split it off. It's another issue which cause no harm at > all > today, but fails as soon as someone tries to perform multi inserts into the > catalog.
Yep. I was wondering how we should do that for some time, but I was not able to come back to it. + /* + * CONTAINS_NEW_TUPLE will always be set unless the multi_insert was + * performed for a catalog. If it is a catalog, return immediately as + * there is nothing to logically decode. + */ + if (!(xlrec->flags & XLH_INSERT_CONTAINS_NEW_TUPLE)) + return; Hmm, OK. Consistency with DecodeInsert() is a good idea here, so count me in regarding the way your patch handles the problem. I would be fine to apply that part but, Andres, perhaps you would prefer taking care of it yourself? -- Michael
signature.asc
Description: PGP signature
