Hi, On 2020-02-23 16:27:57 +0900, Michael Paquier wrote: > On Sat, Feb 22, 2020 at 10:22:27PM +0100, Daniel Gustafsson wrote: > > Turns out that we in heap_multi_insert missed to call log_heap_new_cid for > > the > > first tuple inserted, we only do it in the loop body for the subsequent > > ones. > > With the attached patch, the v6 of this patch posted upthead pass the tests > > for > > me. I have a v7 brewing which I'll submit shortly, but since this fix > > unrelated to that patchseries other than as a pre-requisite I figured I'd > > post > > that separately.
Thanks for finding! > Good catch. I would not backpatch that as it is not a live bug > because heap_multi_insert() is not used for catalogs yet. With your > patch, that would be the case though.. Thanks for pushing. I do find it a bit odd that you essentially duplicated the existing comment in a different phrasing. What's the point? Greetings, Andres Freund
