On Tue, Jan 21, 2020 at 2:46 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Jan 21, 2020 at 12:51 PM Masahiko Sawada > <masahiko.saw...@2ndquadrant.com> wrote: > > > > On Tue, 21 Jan 2020 at 16:13, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > SizeOfLVDeadTuplesHeader is not defined by patch. Do you think it > > > makes sense to add a comment here about the calculation? > > > > Oops, it should be SizeOfLVDeadTuples. Attached updated version. > > > > I defined two macros: SizeOfLVDeadTuples is the size of LVDeadTuples > > struct and SizeOfDeadTuples is the size including LVDeadTuples struct > > and dead tuples. > > > > I have reproduced the issue by defining MaxAllocSize as 10240000 and > then during debugging, skipped the check related to LAZY_ALLOC_TUPLES. > After patch, it fixes the problem for me. I have slightly modified > your patch to define the macros on the lines of existing macros > TXID_SNAPSHOT_SIZE and TXID_SNAPSHOT_MAX_NXIP. What do you think > about it? > > Andres, see if you get a chance to run the test again with the > attached patch, otherwise, I will commit it tomorrow morning. > Patch looks fine to me except, we better use parentheses for the variable passed in macro.
+#define MAXDEADTUPLES(max_size) \ + ((max_size - offsetof(LVDeadTuples, itemptrs)) / sizeof(ItemPointerData)) change to -> (((max_size) - offsetof(LVDeadTuples, itemptrs)) / sizeof(ItemPointerData)) -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
