On 2019-Dec-02, Yugo Nagata wrote: > On Mon, 02 Dec 2019 10:36:36 +0900 (JST) > Tatsuo Ishii <is...@sraoss.co.jp> wrote: > > > >> One thing pending in this development line is how to catalogue aggregate > > >> functions that can be used in incrementally-maintainable views. > > >> I saw a brief mention somewhere that the devels knew it needed to be > > >> done, but I don't see in the thread that they got around to doing it. > > >> Did you guys have any thoughts on how it can be represented in catalogs? > > >> It seems sine-qua-non ...
> > > In the first option, we support only built-in aggregates which we know > > > able > > > to handle correctly. Supported aggregates can be identified using their > > > OIDs. > > > User-defined aggregates are not supported. I think this is the simplest > > > and > > > easiest way. > > > > I think this is enough for the first cut of IVM. So +1. > > If there is no objection, I will add the check of aggregate functions > by this way. Thanks. The way I imagine things is that there's (one or more) new column in pg_aggregate that links to the operator(s) (or function(s)?) that support incremental update of the MV for that aggregate function. Is that what you're proposing? All that query-construction business in apply_delta() looks quite suspicious. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services