On Sat, Oct 5, 2019 at 5:23 PM Nikolay Shaplov <dh...@nataraj.su> wrote: > This thread is a follow up to the thread > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've > been trying to remove StdRdOptions > structure and replace it with unique structure for each relation kind. > > I've decided to split that patch into smaller parts. > > This part adds some asserts to ViewOptions macroses. > Since an option pointer there is converted into (ViewOptions *) it would be > really good to make sure that this macros is called in proper context, and we > do the convertation properly. At least when running tests with asserts turned > on.
Seems like a good idea. Should we try to do something similar for the macros in that header file that cast to StdRdOptions? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
