On Mon, Sep 30, 2019 at 5:03 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote: > > I think that the above checks are always true because isnt() function > > checks if the 1st argument and 2nd argument are not the same. > > Dammit. I overlooked this part of the module's doc. > > > I've attached the updated version patch including the tests. Please > > review it. > > Thanks, your test allows to reproduce the original problem, so that's > nice. I don't have much to say, except some improvements to the > comments of the test as per the attached. What do you think?
Thank you for updating! The comment in your patch is much better. Regards, -- Masahiko Sawada
