On Fri, Sep 27, 2019 at 5:09 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Sep 27, 2019 at 01:51:25PM +0900, Masahiko Sawada wrote: > > On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao <masao.fu...@gmail.com> wrote: > >> What about moving the logic that removes RECO VERYXLOG and > >> RECOVERYHISTORY from exitArchiveRecovery() and performing it > >> just before/after RemoveNonParentXlogFiles()? Which looks simple. > > > > Agreed. Attached the updated patch. > > Mea culpa here, I have just noticed the thread. Fujii-san, would you > prefer if I take care of it? And also, what's the issue with not > doing the removal of both files just after writeTimeLineHistory()? > That's actually what happened before cbc55da5.
So you think that it's better to remove them just after writeTimeLineHistory()? Per the following Sawada-san's comment, I was thinking that idea is basically not good. And, RemoveNonParentXlogFiles() also removes garbage files from pg_wal. It's simpler if similar codes exist near. Thought? Regards, -- Fujii Masao
