On Tue, Sep 03, 2019 at 08:06:43AM +0200, Fabien COELHO wrote: > Attached is a rebase after TestLib.pm got a documentation in > 6fcc40b1.
I am not completely sure what to think about this patch, but here are some high-level comments. +=item $node->icommand_checks(cmd, ...) + +=cut + +sub icommand_checks Surely this can have a better description, like say PostgresNode::command_checks_all. Is Expect compatible down to perl 5.8.0 which is the minimum required for the TAP tests (see src/test/perl/README)? There are cases where we don't support tab completion, aka no USE_READLINE. So tests would need to be skipped. - \a \C arg1 \c arg1 arg2 arg3 arg4 \cd arg1 \conninfo + \a + \C arg1 Why are you changing that? Your patch does not touch the logic of psql. Could it make sense as a separate patch to shape better the tests? --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -307,6 +307,7 @@ describeTablespaces(const char *pattern, bool verbose) * a for aggregates * n for normal + * p for procedure This is a separate issue, fixed. -- Michael
signature.asc
Description: PGP signature
