On 07/08/2019 14:42, Thomas Munro wrote:
On Wed, Aug 7, 2019 at 11:28 PM Heikki Linnakangas <hlinn...@iki.fi> wrote:
The list of tests in src/test/isolation/isolation_schedule has grown
over the years. Originally, they were all related to Serializable
Snapshot Isolation, but there are different kinds of concurrency tests
there now. More tests is good, but the schedule file has grown into a
big inscrutable list with zero comments.
+1
I propose to categorize the tests and add some divider comments to the
file, see attached.
I think I'd put nowait and skip locked under a separate category "FOR
UPDATE" or "row locking" or something, but maybe that's just me... can
you call that stuff DML?
Yeah, I guess SELECT FOR UPDATE isn't really DML. Separate "Row locking"
category works for me. Or maybe "Concurrent DML and row locking". There
is also DML in some of those tests.
- Heikki
