On 8/7/19 12:00 PM, Michael Paquier wrote:
On Wed, Aug 07, 2019 at 10:53:45AM +0200, Magnus Hagander wrote:
To me this sounds like a classic non-English-native-speaker-mistake. But
it seems at least the one in the docs come from Bruce, who definitely is...
So perhaps it's intentional to refer to "what pg_rewind does", and not
necessarily to the regular word for it?
I am not sure :)
"rewound" sounds much more natural.
--
Michael
+1 for rewound from a non-English-native-speaker. The use of "rewound"
in the same file also supports Michael's view.
If we decide to fix this, we should probably revise and back-patch the
whole paragraph where it appears as it seems to mix up scanning target
cluster
WALs and applying source cluster WALs. A small patch is attached for
your consideration (originally proposed on pgsql-docs [1]).
[1]
https://www.postgresql.org/message-id/ad6ac5bb-6689-ddb0-dc60-c5fc197d728e%40postgrespro.ru
--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
diff --git a/doc/src/sgml/ref/pg_rewind.sgml b/doc/src/sgml/ref/pg_rewind.sgml
index 52a1caa..a7e1705 100644
--- a/doc/src/sgml/ref/pg_rewind.sgml
+++ b/doc/src/sgml/ref/pg_rewind.sgml
@@ -66,14 +66,12 @@ PostgreSQL documentation
can be found either on the target timeline, the source timeline, or their common
ancestor. In the typical failover scenario where the target cluster was
shut down soon after the divergence, this is not a problem, but if the
- target cluster ran for a long time after the divergence, the old WAL
+ target cluster ran for a long time after the divergence, its old WAL
files might no longer be present. In that case, they can be manually
- copied from the WAL archive to the <filename>pg_wal</filename> directory, or
- fetched on startup by configuring <xref linkend="guc-primary-conninfo"/> or
- <xref linkend="guc-restore-command"/>. The use of
- <application>pg_rewind</application> is not limited to failover, e.g. a standby
- server can be promoted, run some write transactions, and then rewinded
- to become a standby again.
+ copied from the WAL archive to the <filename>pg_wal</filename> directory.
+ The use of <application>pg_rewind</application> is not limited to failover,
+ e.g. a standby server can be promoted, run some write transactions, and then
+ get rewound to become a standby again.
</para>
<para>
