On Mon, Jul 22, 2019 at 01:25:41PM -0400, Jesper Pedersen wrote: > Hi, > > On 7/21/19 9:48 PM, Michael Paquier wrote: > > > Since pg_receivewal does not apply WAL, you should not allow it to > > > become a synchronous standby when synchronous_commit = remote_apply. > > > If it does, it will appear to be a standby which never catches up, > > > which may cause commits to block. To avoid this, you should either > > > configure an appropriate value for synchronous_standby_names, or > > > specify an application_name for pg_receivewal that does not match it, > > > or change the value of synchronous_commit to something other than > > > remote_apply. > > > > > > I think that'd be a lot more useful than enumerating the total-failure > > > scenarios. > > > > +1. Thanks for the suggestions! Your wording looks good to me. > > +1 > > Here is the patch for it, with Robert as the author.
> + <xref linkend="guc-synchronous-commit"/> to something other than Looks fine to me. Just a tiny nit. For the second reference to synchronous_commit, I would change the link to a <varname> markup. -- Michael
signature.asc
Description: PGP signature
