> On 8 Jul 2019, at 00:02, Thomas Munro <thomas.mu...@gmail.com> wrote: > > On Wed, Jun 12, 2019 at 1:21 AM Daniel Gustafsson <dan...@yesql.se> wrote: >> The patch is still rough around the edges (TODO’s left to mark some areas), >> but >> I prefer to get some feedback early rather than working too far in >> potentially >> the wrong direction, so parking this in the CF for now. > > Hi Daniel, > > Given the above disclaimers the following may be entirely expected, > but just in case you weren't aware: > t/010_logical_decoding_timelines.pl fails with this patch applied. > > https://travis-ci.org/postgresql-cfbot/postgresql/builds/555205042
I hadn’t seen since I had fat-fingered and accidentally run the full tests in a
tree without assertions. The culprit here seems to an assertion in the logical
decoding code which doesn’t account for heap_multi_insert into catalog
relations (which there are none now, this patch introduce them and thus trip
the assertion). As the issue is somewhat unrelated, I’ve opened a separate
thread with a small patch:
https://postgr.es/m/cbffd532-c033-49eb-9a5a-f67eaee9e...@yesql.se
The attached v3 also has that fix in order to see if the cfbot is happier with
this.
cheers ./daniel
catalog_multi_insert-v3.patch
Description: Binary data
