On 2019-07-02 22:56, Tom Lane wrote: > I took a look through these and see nothing objectionable. There are > probably more places that can be improved, but we need not insist on > getting every such place in one go. > > Per Robert's position that variables ought to have well-defined widths, > there might be something to be said for not touching the variable > declarations that you changed from int64 to long long, and instead > casting them to long long in the sprintf calls. But I'm not really > convinced that that's better than what you've done. > > Marked CF entry as ready-for-committer.
committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
