Hi, On June 5, 2019 12:14:42 PM PDT, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: >On 2019-Jun-05, Andres Freund wrote: > >> I'd much rather see this tackled in a general way than fiddling with >> individual datatypes. I think we should: >> >> 1) make fetch_att(), store_att_byval() etc support datums of any >length >> between 1 and <= sizeof(Datum). Probably also convert them to >inline >> functions. There's a few more functions to be adjusted, but not >many, >> I think. > >Does this mean that datatypes that are >4 and <=8 bytes need to handle >both cases? Is it possible for them to detect the current environment?
Well, the conversion macros need to know. You can look at float8 for an example of the difference - it's pretty centralized. We should provide a few helper macros to abstract that away. Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
