On Tue, Apr 9, 2019 at 1:07 PM Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > Hello. > > At Mon, 8 Apr 2019 19:22:04 +0900, Fujii Masao <masao.fu...@gmail.com> wrote > in <CAHGQGwHa_dX=drcbr5qvts6w5mgcy3qz2fewreaixpes1b2...@mail.gmail.com> > > > "TRUNCATE" option for vacuum command should be added to the open items? > > > > Yes, I think. > > Attached is the patch which adds TRUNCATE option into VACUUM. > > By the way, this might have been discussed upthread, but boolean > options of VACUUM command is defaulted to true. So, it seems to > me that the name is better (or convenient to me) to be > SKIP_TRUNCATE. The name of the reloption seems good to me.
If we really use SKIP_TRUNCATE, we need to use SKIP_INDEX_CLEANUP instead of INDEX_CLEANUP for the consistency. But TRUNCATE and INDEX_CLEANUP look more intuitive to me than SKIP_TRUNCATE and SKIP_INDEX_CLEANUP. Regards, -- Fujii Masao
