On Thu, Apr 4, 2019 at 1:23 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Thu, Apr 4, 2019 at 1:26 PM Tsunakawa, Takayuki > <tsunakawa.ta...@jp.fujitsu.com> wrote: > > > > From: Fujii Masao [mailto:masao.fu...@gmail.com] > > > reloption for TOAST is also required? > > > > # I've come back to the office earlier than planned... > > > > Hm, there's no reason to not provide toast.vacuum_shrink_enabled. Done > > with the attached patch. > > > > Thank you for updating the patch!
+1! > + <term><literal>vacuum_shrink_enabled</literal>, > <literal>toast.vacuum_shrink_enabled</literal> > (<type>boolean</type>)</term> > + <listitem> > + <para> > + Enables or disables shrinking the table when it's vacuumed. > + This also applies to autovacuum. > + The default is true. If true, VACUUM frees empty pages at the > end of the table. > > "VACUUM" needs <command> or "vacuum" is more appropriate here? also, the documentation should point out that freeing is not guaranteed. Something like + The default is true. If true, VACUUM will try to free empty pages at the end of the table. > I'm not sure the consensus we got here but we don't make the vacuum > command option for this? I don't think here's a clear consensus, but my personal vote is to add it, with SHRINK_TABLE = [ force_on | force_off | default ] (unless a better proposal has been made already)
