On 2019/04/03 3:10, David Rowley wrote: > On Wed, 3 Apr 2019 at 01:26, Amit Langote <amitlangot...@gmail.com> wrote: >> +#include "nodes/pathnodes.h" >> ... >> +partitions_are_ordered(struct RelOptInfo *partrel) >> >> Maybe, "struct" is unnecessary? > > I just left it there so that the signature matched the header file. > Looking around for examples I see make_partition_pruneinfo() has the > structs only in the header file, so I guess that is how we do things, > so changed to that in the attached.
Ah, I see. Thanks for updating the patch. I don't have any more comments. Thanks, Amit