Hi David, On Tue, Apr 2, 2019 at 8:49 PM David Rowley <david.row...@2ndquadrant.com> wrote: > I ended up rewording the entire thing and working on the header > comment for the function too. I think previously it wasn't that well > defined what "ordered" meant. I added a mention that we expect that > NULLs, if possible must come in the last partition.
Thanks for the updated patch. New descriptions look good, although was amused by this: diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.c index bdd0d23854..9dd378d7a0 100644 --- a/src/backend/partitioning/partbounds.c +++ b/src/backend/partitioning/partbounds.c @@ -25,6 +25,7 @@ #include "miscadmin.h" #include "nodes/makefuncs.h" #include "nodes/nodeFuncs.h" +#include "nodes/pathnodes.h" ... +partitions_are_ordered(struct RelOptInfo *partrel) Maybe, "struct" is unnecessary? Thanks, Amit
