On Thu, 14 Mar 2019 at 06:24, Robert Haas <robertmh...@gmail.com> wrote: > > On Wed, Mar 13, 2019 at 1:09 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Sergei Kornilov <s...@zsrv.org> writes: > > >> Ugh, I guess so. Or how about changing the message itself to use > > >> INFO, like we already do in QueuePartitionConstraintValidation? > > > > > Fine for me. But year ago this was implemented in my patch and Tom voted > > > against using INFO level for such purpose: > > > https://www.postgresql.org/message-id/1142.1520362313%40sss.pgh.pa.us > > > > What I thought then was that you didn't need the message at all, > > at any debug level. I still think that. It might have been useful > > for development purposes but it does not belong in committed code. > > INFO (making it impossible for anybody to not have the message > > in-their-face) is right out. > > I find that position entirely wrong-headed. If you think users have > no interest in a message telling them whether their gigantic table is > getting scanned or not, you're wrong. Maybe you're right that > everyone doesn't want it, but I'm positive some do. We've had > requests for very similar things on this very mailing list more than > one.
If we don't have this for SET NOT NULL then we should either add it or remove the one from ATTACH PARTITION. I don't think we need to decide which it is now, so I've added an item to the open items list that this is out for debate. https://wiki.postgresql.org/wiki/PostgreSQL_12_Open_Items#Open_Issues I think we can mark this patch as committed now as I don't think the lack of a way to test it is likely to cause it to be reverted. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
