On 2019-Feb-26, Dmitry Dolgov wrote: > > On Tue, Feb 26, 2019 at 6:38 AM Michael Paquier <mich...@paquier.xyz> wrote: > > > > Works for me. With a quick read of the code, it seems to me that it > > is possible to keep compatibility while keeping the simplifications > > around ArchiveEntry()'s refactoring. > > Yes, it should be rather simple, we can e.g. return to the old less consistent > NULL handling approach something (like in the attached patch), or replace a > NULL > value with an empty string in WriteToc. Give me a moment, I'll check it out. > At > the same time I would suggest to keep replace_line_endings -> sanitize_line, > since it doesn't break compatibility.
I think it would be better to just put back the .defn = "" (etc) to the ArchiveEntry calls. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
