On Wed, Dec 26, 2018 at 07:43:17PM +0100, Fabien COELHO wrote: >> It adds an (now mandatory) --action parameter that takes either verify, >> enable or disable as argument. > > I'd rather have explicit switches for verify, enable & disable, and verify > would be the default if none is provided.
Okay, noted for the separate switches. But I don't agree with the point of assuming that --verify should be enforced if no switches are defined. That feels like a trap for newcomers of this tool.. > For enable/disable, while the command is running, it should mark the cluster > as opened to prevent an unwanted database start. I do not see where this is > done. You have pretty much the same class of problems if you attempt to start a cluster on which pg_rewind or the existing pg_verify_checksums is run after these have scanned the control file to make sure that they work on a cleanly-stopped instance. In short, this is a deal between code simplicity and trying to have the tool outsmart users in the way users use the tool. I tend to prefer keeping the code simple and not worry about cases where the users mess up with their application, as there are many more things which could go wrong. -- Michael
signature.asc
Description: PGP signature
