> On 2 Nov 2018, at 15:42, Tom Lane <t...@sss.pgh.pa.us> wrote: > > I wrote: >> Here's a lightly-tested patch for that approach. > > Anybody have an opinion about which approach to use? We need to choose > one, and PDQ too, if we want full buildfarm coverage on it before Monday's > wrap.
Sorry for being slow to respond, I was hoping to find time for testing but it’s a scarce resource right now. > The main argument in favor of #1 (restore use of -isysroot) is fear that > Apple's going to force us into that sometime soon anyhow, so we might as > well just bite the bullet instead of inserting weird workarounds to avoid > it. But perhaps that isn't going to happen. #1 is the option that appeals to me the most, mostly because it removes all possible ambiguity of when/if it’s required compared to #2. + Most Postgres developers just turn off SIP, though. Minor nitpick, shouldn’t this be <productname>Postgres</productname>? cheers ./daniel
