>>>>> "Tomas" == Tomas Vondra <tomas.von...@2ndquadrant.com> writes:
> On 10/26/2018 12:28 PM, Surafel Temesgen wrote: >> hello , >> >> The WITH TIES keyword is sql standard that specifies any peers of >> retained rows to retained in the result set too .which means >> according to ordering key the result set can includes additional rows >> which have ties on the last position, if there are any and It work >> with ORDER BY query. Tomas> Thanks for the patch. I've looked at it today, and it seems Tomas> mostly OK, with a couple of minor issues. Most of it is code Tomas> formatting and comment wording issues, so I'm not going to go Tomas> through them here - see the attached 0002 patch (0001 is your Tomas> patch, rebased to current master). I still think that this is the wrong approach. Implementing WITH TIES and PERCENT together using an implicit window function call kills two birds with one very small stone (the only executor change needed would be teaching LIMIT to be able to stop on a boolean condition), with maximum reuse of existing facilities. -- Andrew (irc:RhodiumToad)
