Re: Report bytes and transactions actually sent downtream

[Ashutosh Sharma]

Hi Masahiko-san,

On Fri, Jul 3, 2026 at 3:20 AM Masahiko Sawada <sawada.m...@gmail.com> wrote:
>
> Could you swap these patches' order? I think that these patches are
> independent of each other and while we have an agreement on the new
> statistics, we still need discussion for the refactoring part
> (particularly I guess it's better to avoid including pgstatt.h in
> reorderbuffer.h)
>

Thank you for your review comments.

I have swapped the patch order - please see attached.

In the refactoring patch, I also ensured that reorderbuffer.h does not
depend on pgstat.h. To make that possible, I introduced a shared
header, src/include/replication/replslot_stats.h, where
PgStat_ReplSlotStats is defined. Both pgstat.h and reorderbuffer.h
include that header. Hope that helps!

--
With Regards,
Ashutosh Sharma.

v20260703-0001-Report-output-bytes-in-pg_stat_replication_slots.patch
Description: Binary data

v20260703-0002-Refactor-replication-slot-decoding-stats-handling.patch
Description: Binary data