Hi, > > FWIW, even after sleeping on it, I don't think that this patch is > > going in the right direction. I am pretty sure that we should just > > lift the ACL check in get_all_vacuum_rels() and always require > > vacuum_is_permitted_for_relation() to have the relation locked when > > called. This way we would rely on one single code path for the ACL > > check, even if it means holding a reference of a relation OID for > > something to be processsed later. So I would revisit the choice made > > FWIW, I agree with this direction.
This direction is also OK for me. We might want to fix get_tables_to_repack() together? -- Regards, ChangAo Chen
