On Tue, Jun 16, 2026 at 12:26 PM Baji Shaik <[email protected]> wrote:

> On Tue, Jun 16, 2026 at 11:14 AM Nathan Bossart <[email protected]>
> wrote:
>
>> I'm curious why you added this check to the beginning and surrounded the
>> rest with parentheses.  Wouldn't it be better to follow the example of the
>> surrounding clauses and an "AND NOT p.inherited" somewhere in the middle?
>
>
> Good point. v2 moves the check inside the EXISTS as
> "AND NOT p.inherited", consistent with how the inheritance
> sections below handle it.
>
> v2 attached.
>
> Thanks,
> Baji Shaik.
>

+1

The refactor I was testing differed only in having the new qual one line
higher (above the attstattarget check vs below it). Looks good to me.

Reply via email to