On Wed, Oct 15, 2025 at 7:38 PM shveta malik <[email protected]> wrote: > > On Wed, Oct 15, 2025 at 9:57 AM Ajin Cherian <[email protected]> wrote: > > > > > > Updated the patch with a tap test. > > Attaching patch v17 which has a tap test to test the feature added. > > > > Thanks for the patch. I noticed that in the case of API, we are > passing 'some_slot_updated' as always false to > wait_for_slot_activity(). Shouldn't we pass it as actual value just > like slotsync worker does? There may be a case that in a given cycle, > one of the temp slots is persisted or one of the persisted slots is > updated, in such a case we should not double the naptime. The naptime > doubling logic is only when there is no activity happening on primary. >
I've modified this accordingly On Wed, Oct 15, 2025 at 8:29 PM shveta malik <[email protected]> wrote: > > On Wed, Oct 15, 2025 at 2:08 PM shveta malik <[email protected]> wrote: > > > > On Wed, Oct 15, 2025 at 9:57 AM Ajin Cherian <[email protected]> wrote: > > > > > > > > > Updated the patch with a tap test. > > > Attaching patch v17 which has a tap test to test the feature added. > > > > > > > Test also needs correction. It seems the existing test of 'Test > logical failover slots corresponding to different plugins can be > synced to the standby.' is disturbed. If it is already tested and need > not be covered again, then comments need to be changed to clarify > that; otherwise the test needs to be brought back. I've modified the comments to reflect the new changes. attaching patch v18 with the above changes. regards, Ajin Cherian Fujitsu Australia
v18-0001-Improve-initial-slot-synchronization-in-pg_sync_.patch
Description: Binary data
