Hi,
While working on the thread [1]. We encountered that in the
'AlterPublicationTables' function, the assignment 'isnull = true' is
redundant. This assignment is not required, and the variable will be
reassigned before use.
I have attached a patch to address this.
[1]:
https://www.postgresql.org/message-id/CALdSSPgiDj8S8POf_6kiUkVrt9-EqYmn%2B2ahDqpdBpyteeAz-Q%40mail.gmail.com
Thanks,
Shlok Kyal
From 1a42b5160f1707ba75ae0e4462f47b9dbaca8176 Mon Sep 17 00:00:00 2001
From: Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: Wed, 20 Aug 2025 11:18:26 +0530
Subject: [PATCH v1] Remove redundant assignment of isnull variable
in the 'AlterPublicationTables' function, the assignment 'isnull = true'
is redundant. This assignment is not required, and the variable will be
reassigned before use.
---
src/backend/commands/publicationcmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c
index 803c26ab216..07edd480843 100644
--- a/src/backend/commands/publicationcmds.c
+++ b/src/backend/commands/publicationcmds.c
@@ -1259,7 +1259,7 @@ AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,
*/
if (HeapTupleIsValid(rftuple))
{
- bool isnull = true;
+ bool isnull;
Datum whereClauseDatum;
Datum columnListDatum;
--
2.34.1
