> On 23 Apr 2025, at 13:32, m.korot...@postgrespro.ru wrote:
>
> I found a case of potential NULL pointer dereference.
> In src/backend/utils/hash/dynahash.c in function HTAB *hash_create() the
> result of the DynaHashAlloc() is used unsafely.
> The function DynaHashAlloc() calls MemoryContextAllocExtended() with
> MCXT_ALLOC_NO_OOM and can return a NULL pointer.
> Added the pointer check for avoiding a potential problem.
Yeah, good catch.
And all HTAB->alloc() (which relies on DynaHashAlloc) callers seem to check for
NULL result.
It seems there are a lot of cases of MCXT_ALLOC_NO_OOM, perhaps should we check
them all?
Best regards, Andrey Borodin.
