On Fri, 4 Apr 2025 at 01:17, Andrew Dunstan <and...@dunslane.net> wrote: > > > On 2025-04-01 Tu 1:59 AM, Mahendra Singh Thalor wrote: > > On Mon, 31 Mar 2025 at 23:43, Álvaro Herrera <alvhe...@alvh.no-ip.org> > > wrote: > >> Hi > >> > >> FWIW I don't think the on_exit_nicely business is in final shape just > >> yet. We're doing something super strange and novel about keeping track > >> of an array index, so that we can modify it later. Or something like > >> that, I think? That doesn't sound all that nice to me. Elsewhere it > >> was suggested that we need some way to keep track of the list of things > >> that need cleanup (a list of connections IIRC?) -- perhaps in a > >> thread-local variable or a global or something -- and we install the > >> cleanup function once, and that reads from the variable. The program > >> can add things to the list, or remove them, at will; and we don't need > >> to modify the cleanup function in any way. > >> > >> -- > >> Álvaro Herrera Breisgau, Deutschland — > >> https://www.EnterpriseDB.com/ > > Thanks Álvaro for the feedback. > > > > I removed the old handling of on_exit_nicely_list from the last patch > > set and added one simple function to just update the archive handle in > > shutdown_info. (shutdown_info.AHX = AHX;) > > > > For first database, we will add entry into on_exit_nicely_list array > > and for rest database, we will update only shutdown_info as we already > > closed connection for previous database.With this fix, we will not > > touch entry of on_exit_nicely_list for each database. > > > > Here, I am attaching updated patches. > > > > > OK, looks good. here's my latest. I'm currently working on tidying up > docco and comments. > > > cheers > > > andrew > > > > > -- > Andrew Dunstan > EDB: https://www.enterprisedb.com
Thanks Andrew for the updated patches. Here, I am attaching a delta patch with some more TAP-test cases. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
delta_0004-some-negative-TAP-test-case-for-pg_restore-when-dump.noci
Description: Binary data
