On 2025-04-15 Tu 2:30 PM, Mahendra Singh Thalor wrote:
Hi Andrew, I did some refactoring to find out dump file extensions(.dmp/.tar etc) in pg_restore. With the attached patch, we will not try to find out file extension with each database, rather we will find out before the loop. Here, I am attaching a patch for the same. Please have a look over this.
That doesn't look right at first glance. You shouldn't have to tell pg_restore what format to use, it should be able to intuit it from the dumps (and that's what the docs say it does).
The saving here would be hardly measurable anyway - you would be in effect saving one or two stat calls per database.
cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
