Jeff Davis <pg...@j-davis.com> writes:
> On Tue, 2025-03-18 at 11:11 -0400, Tom Lane wrote:
>> Also, probably better to make it const:
>>
>> -static const pg_wchar *casekind_map[NCaseKind] =
>> +static const pg_wchar * const casekind_map[NCaseKind] =
> Was this a general suggestion, or did you see something in particular
> that would make it more optimizable this way?
No, just a general style position that tables that aren't supposed
to change should be const. Cases like this are a tad insidious
because it looks like you did make the table const, only you didn't.
regards, tom lane
