On Tue, 2025-03-18 at 11:11 -0400, Tom Lane wrote:
> It's not apparent to me why that table needs to be in a header
> file and not in the sole user .c file?
Thank you, fixed.
> Also, probably better to make it const:
>
> -static const pg_wchar *casekind_map[NCaseKind] =
> +static const pg_wchar * const casekind_map[NCaseKind] =
Fixed also (except pgindent had a slightly different opinion about
spaces).
Was this a general suggestion, or did you see something in particular
that would make it more optimizable this way?
Regards,
Jeff Davis
