On 2/21/25 09:09, Benoit Lobréau wrote:
On 2/20/25 4:40 PM, David Steele wrote:
Benoit -- this was your idea. Did you want to submit a patch yourself?

Here is an attempt at that. I kept the wording I used above. Is it fine to repeat the whole ereport block twice?

I think for translation purposes this is probably how it needs to be but I wonder if we could do something like:

errdetail("Latest checkpoint in %s is at %X/%X <...>",
          haveBackupLabel ? "pg_control" ? "backup_label",

I'll defer to Michael on that.

In general this patch and the new messages look good to me, though.

Regards,
-David


Reply via email to