On Fri, Feb 21, 2025 at 3:37 PM Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > > > > On Fri, Feb 21, 2025 at 2:59 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> > wrote: >> >> On Fri, Feb 21, 2025 at 11:43 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> >> wrote: >> > >> > I have not looked at the pg_dump code yet, so the changes included here >> > are just pgindent. >> > >> >> I ran pg_upgrade suite with the patches. 002_pg_upgrade fails with >> following test log > > > This is strange because when I run the tests it's all passing for me. > > # +++ tap check in src/bin/pg_upgrade +++ > t/001_basic.pl .......... ok > t/002_pg_upgrade.pl ..... ok > t/003_logical_slots.pl .. ok > t/004_subscription.pl ... ok > All tests successful. > Files=4, Tests=53, 38 wallclock secs ( 0.01 usr 0.00 sys + 2.88 cusr 2.11 > csys = 5.00 CPU) > Result: PASS > > Note: I applied the patch on commit 7202d72787d3b93b692feae62ee963238580c877.
I applied patches on 984410b923263cac901fa81e0efbe523e9c36df3 and I am using meson. If I apply your patches, build binaries, I see failure. I reverted your patches, built binaries, I don't see failure. I apply your patches again, built binaries, it fails again. -- Best Wishes, Ashutosh Bapat
