On Fri, Feb 21, 2025 at 2:59 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote:
> On Fri, Feb 21, 2025 at 11:43 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > > > I have not looked at the pg_dump code yet, so the changes included here > > are just pgindent. > > > > I ran pg_upgrade suite with the patches. 002_pg_upgrade fails with > following test log > This is strange because when I run the tests it's all passing for me. # +++ tap check in src/bin/pg_upgrade +++ t/001_basic.pl .......... ok t/002_pg_upgrade.pl ..... ok t/003_logical_slots.pl .. ok t/004_subscription.pl ... ok All tests successful. Files=4, Tests=53, 38 wallclock secs ( 0.01 usr 0.00 sys + 2.88 cusr 2.11 csys = 5.00 CPU) Result: PASS Note: I applied the patch on commit 7202d72787d3b93b692feae62ee963238580c877. > not ok 14 - run of pg_upgrade for new instance > not ok 15 - pg_upgrade_output.d/ removed after pg_upgrade success > # === pg_upgrade logs found - appending to > /build/dev/testrun/pg_upgrade/002_pg_upgrade/log/regress_log_002_pg_upgrade > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_16384.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_1.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_server.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_utility.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_16387.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_16385.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_16386.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_internal.log > === > # === appending > > /build/dev/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20250221T144705.724/log/pg_upgrade_dump_5.log > === > not ok 16 - check that locales in new cluster match original cluster > ok 17 - dump after running pg_upgrade > not ok 18 - old and new dumps match after pg_upgrade > 1..18 > # test failed > stderr: > # Failed test 'run of pg_upgrade for new instance' > # at /pg/src/bin/pg_upgrade/t/002_pg_upgrade.pl line 478. > # Failed test 'pg_upgrade_output.d/ removed after pg_upgrade success' > # at /pg/src/bin/pg_upgrade/t/002_pg_upgrade.pl line 487. > # Failed test 'check that locales in new cluster match original cluster' > # at /pg/src/bin/pg_upgrade/t/002_pg_upgrade.pl line 522. > # got: '0|c|en_US.UTF-8|en_US.UTF-8|' > # expected: '6|b|C|C|C.UTF-8' > # Failed test 'old and new dumps match after pg_upgrade' > # at /pg/src/test/perl/PostgreSQL/Test/Utils.pm line 797. > # got: '1' > # expected: '0' > # Looks like you failed 4 tests of 18. > > (test program exited with status code 4) > > ------------------------------------------------------------------------------ > > -- > Best Wishes, > Ashutosh Bapat > -- Rushabh Lathia
